Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add form validation for zoom google meet #1812

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

angela-lee1
Copy link
Member

@angela-lee1 angela-lee1 commented Nov 13, 2024

Fixes #1511

What changes did you make and why did you make them ?

  • modify validateLink for Zoom and Google meet link
  • Zoom and Google Meet links are validated at create new recurring event

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

![image](
Screenshot 2024-11-12 at 2 22 43 PM
)

Visuals after changes are applied

![image](
Screenshot 2024-11-12 at 8 55 37 PM

)

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b angela-lee1-add-form-validation-zoom-google-meet development
git pull https://github.com/angela-lee1/VRMS.git add-form-validation-zoom-google-meet

update feature branch with latest change from development
Copy link
Member

@nora-zajzon nora-zajzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am having trouble getting approved links to work. I tried with both google meet and zoom and both of them seem to return Invalid Link. I could be the one doing it wrong but I am not sure how else to try.
Screenshot 2024-11-17 at 4 29 39 PM
Screenshot 2024-11-17 at 4 30 19 PM

@angela-lee1
Copy link
Member Author

angela-lee1 commented Nov 18, 2024

@nora-zajzon, for Google Meet: Did you have a link like https://meet.google.com/bgc-szbm-osr? I was able to add it. Can you retry?
For the Zoom meeting: At the moment, the Zoom regex won't match Zoom meeting URLs with a subdomain like ucsd. Will HackforLA use Zoom meetings with subdomains? I can add that.
Hope this helps, and thank you for reviewing my PR.

Hi @JackHaeg and @trillium, do we allow users to enter relative URLs (those that omit https://)? Also, do we permit users to use Zoom meeting URLs with subdomains? I will move forward based on your feedback.

Screenshot 2024-11-17 at 6 46 19 PM
Screenshot 2024-11-17 at 6 46 05 PM

Screenshot 2024-11-17 at 7 07 46 PM
Screenshot 2024-11-17 at 7 07 56 PM

@trillium
Copy link
Member

trillium commented Nov 19, 2024

Do we allow users to enter relative URLs (those that omit https://)?

Yes, please allow for the https:// to be ommitted, as well as www.

Also, do we permit users to use Zoom meeting URLs with subdomains?

Also yes

Thanks for asking for clarification!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Form Validation for Google Meet & Zoom
3 participants