Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting the height of UserManagment.js to disable extra scrolling #1563

Conversation

freaky4wrld
Copy link
Member

Fixes #1561

What changes did you make and why did you make them ?

  • removed the extra bottom margin from the component with id container-usermanagement to disable the extra scrolling functionality of the component
  • This was done to make the UI in accordance to the design specified and correcting the height would result in enhancing the User experience as we have nothing below Add new user button

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

image
Screenshot 2024-01-22 at 10 32 03 AM
image

Visuals after changes are applied

image
Screenshot 2024-01-22 at 10 31 27 AM

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b freaky4wrld-update-component-height-in-UserManagement-UI-1561 development
git pull https://github.com/freaky4wrld/VRMS.git update-component-height-in-UserManagement-UI-1561

Copy link
Member

@trillium trillium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple fix, thanks!

@trillium trillium merged commit 323826d into hackforla:development Jan 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update component height in UserManagement
2 participants