-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add length validation to description field #1465
add length validation to description field #1465
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Since the |
@MattPereira I see. I assumed it was lumped in with the other new project validation / react hook form work. I'll refactor @spiteless Whats the best path forward here? Its kind of an anti pattern to have to forms written two different ways. Do we edit the ticket, use one form component, or edit the scope ? |
We're going toward getting both the Create and Edit pages being derived from one component with validations passed to the root component (#1471 does this now). Happy to get this validation working and then extend it across the project properly. |
Waiting to merge #1471 first, then this PR will need to be rebased |
@spiteless updated. |
Hey @bkmorgan3 , can you redo these changes on the current version of development. The file location has moved to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you redo these changes on the current version of dev in the new client/src/components/data.js
file and force push?
@spiteless This update to dev was done after my pr was submitted. done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Silly me, I thought there'd be conflicts here but there are not
Fixes #1363
What changes did you make and why did you make them ?