Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add length validation to description field #1465

Merged

Conversation

bkmorgan3
Copy link
Member

Fixes #1363

What changes did you make and why did you make them ?

  • added regex value for all characters, max of 250

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b bkmorgan3-1363/Description-validation development
git pull https://github.com/bkmorgan3/VRMS.git 1363/Description-validation

@MattPereira
Copy link
Contributor

Since the ProjectForm component only controls creating new projects the current state of this PR does not stop existing projects from being updated to have > 250 character descriptions

@bkmorgan3
Copy link
Member Author

bkmorgan3 commented Aug 18, 2023

@MattPereira I see. I assumed it was lumped in with the other new project validation / react hook form work. I'll refactor

@spiteless Whats the best path forward here? Its kind of an anti pattern to have to forms written two different ways. Do we edit the ticket, use one form component, or edit the scope ?

@trillium
Copy link
Member

We're going toward getting both the Create and Edit pages being derived from one component with validations passed to the root component (#1471 does this now). Happy to get this validation working and then extend it across the project properly.

@trillium
Copy link
Member

Waiting to merge #1471 first, then this PR will need to be rebased

@bkmorgan3
Copy link
Member Author

@spiteless updated.

@trillium
Copy link
Member

Hey @bkmorgan3 , can you redo these changes on the current version of development. The file location has moved to client/src/components/data.js and is creating merge conflicts that we can sidestep

Copy link
Member

@trillium trillium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you redo these changes on the current version of dev in the new client/src/components/data.js file and force push?

@bkmorgan3
Copy link
Member Author

@spiteless This update to dev was done after my pr was submitted. done.

Copy link
Member

@trillium trillium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Silly me, I thought there'd be conflicts here but there are not

@trillium trillium merged commit 44c794c into hackforla:development Sep 7, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form Validation - Description
3 participants