Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SplitsCreatorFactoryの機能実装 #209

Merged
merged 5 commits into from
Dec 16, 2024
Merged

SplitsCreatorFactoryの機能実装 #209

merged 5 commits into from
Dec 16, 2024

Conversation

aowheel
Copy link
Collaborator

@aowheel aowheel commented Dec 9, 2024

編集中

@aowheel aowheel marked this pull request as ready for review December 9, 2024 13:09
@aowheel aowheel changed the title WIP: SplitcreatorのOwnable化 SplitsCreatorFactoryの機能実装 Dec 9, 2024
@aowheel
Copy link
Collaborator Author

aowheel commented Dec 9, 2024

関連イシュー

実装

  • createSplitCreatorDeterministic
    • bigbangからのみ呼び出せるように変更
  • setImplementation関数とsetBigBang関数を追加
    • setImplementation
      • SPLITS_CREATOR_IMPLEMENTATIONをonlyOwnerで編集する関数
    • setBigBang
      • BigBangアドレスを編集する関数
  • テストが通るように修正

@aowheel aowheel force-pushed the feature/splitscreator-ownable branch from 57827a5 to f7a311f Compare December 9, 2024 14:04
@yu23ki14 yu23ki14 merged commit 83ea203 into main Dec 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aowheel @yu23ki14