Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolves #29 match colors, spacing, typography to design system #48

Merged
merged 3 commits into from
May 14, 2020
Merged

Resolves #29 match colors, spacing, typography to design system #48

merged 3 commits into from
May 14, 2020

Conversation

tko22
Copy link
Member

@tko22 tko22 commented May 14, 2020 •
edited
Loading

Resolves #29

  • match colors (minor colors were changed - grey palette was made to match other palettes (no midtone and added new darker color))
  • typography (removed hero, fixed sizing for quote + subtitle) - made the order it was defined to match design system spec lol
  • removed scaling for letterSpacing - Remove scaling for some theme attributes #36
  • fixed Tag bug with styled system: styled-system COLORS uses bg, backgroundColor, and color props, which means it will override the prop backgroundColor passed into it. So i made the prop we generate from variant called background instead - its not necessarily a bug, but it may cause confusion (it did for buttons and made everything the light shade of the palette)

David, I will merge this in after yours.. cuz there will be merge conflicts

@tko22 tko22 added bug Something isn't working component for component dev issues labels May 14, 2020
@tko22 tko22 requested review from davidenwang and jackieo5023 May 14, 2020 01:37
@vercel
Copy link

vercel bot commented May 14, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hack4impact/design/f6u7o81dm
✅ Preview: https://design-git-match-designsys.hack4impact1.now.sh

@tko22 tko22 force-pushed the match-designsys branch from b9d6d93 to 3d03856 Compare May 14, 2020 04:56
@tko22 tko22 mentioned this pull request May 14, 2020
Merged
davidenwang
davidenwang approved these changes May 14, 2020
View reviewed changes
Copy link
Contributor

@davidenwang davidenwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beastly

@tko22 tko22 merged commit ec6ff99 into master May 14, 2020
@tko22 tko22 deleted the match-designsys branch May 14, 2020 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidenwang davidenwang davidenwang approved these changes

@jackieo5023 jackieo5023 Awaiting requested review from jackieo5023

Assignees
No one assigned
Labels
bug Something isn't working component for component dev issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix up spacing, breakpoints, colors to match design system
2 participants
@tko22 @davidenwang