Skip to content

Commit

Permalink
Don't strip macos hab cli release
Browse files Browse the repository at this point in the history
Signed-off-by: Scott Macfarlane <[email protected]>
  • Loading branch information
smacfarlane committed Mar 12, 2019
1 parent 150a6a4 commit ab993b9
Showing 1 changed file with 11 additions and 0 deletions.
11 changes: 11 additions & 0 deletions components/hab/habitat/x86_64-darwin/plan.sh
Original file line number Diff line number Diff line change
Expand Up @@ -45,3 +45,14 @@ do_prepare() {
export SODIUM_LIB_DIR=/opt/hab-bundle/embedded/lib
export SODIUM_STATIC=true
}

# Override the do_strip implementation that the x86_64-linux plan.sh includes
#
# TODO(SM): MacOS strip doesn't provide any of --strip-{all,debug,unnecessary}
# that we use in plan-build, so I don't believe we've ever stripped our MacOS
# binaries. Running `file $(which hab)` returns `regular file` which would
# bypass the existing behavior. For now, lets always skip stripping to prevent
# accidental breakages in changes to plan-build.
do_strip() {
return 0
}

0 comments on commit ab993b9

Please sign in to comment.