Skip to content

Commit

Permalink
Merge pull request #6289 from habitat-sh/sm/dont-strip-macos-binaries
Browse files Browse the repository at this point in the history
Don't strip macos hab cli release
  • Loading branch information
christophermaier authored Mar 12, 2019
2 parents 150a6a4 + 1bcfa36 commit 452ec9e
Showing 1 changed file with 12 additions and 0 deletions.
12 changes: 12 additions & 0 deletions components/hab/habitat/x86_64-darwin/plan.sh
Original file line number Diff line number Diff line change
Expand Up @@ -45,3 +45,15 @@ do_prepare() {
export SODIUM_LIB_DIR=/opt/hab-bundle/embedded/lib
export SODIUM_STATIC=true
}

# Override the do_strip implementation that the x86_64-linux plan.sh includes
#
# TODO(SM): MacOS strip doesn't provide any of --strip-{all,debug,unnecessary}
# that we use in plan-build, so I don't believe we've ever stripped our MacOS
# binaries. Running `file $(which hab)` returns `regular file` which would
# bypass the existing behavior. For now, lets always skip stripping to prevent
# accidental breakages from changes to plan-build.
do_strip() {
build_line "Skipping do_strip on x86_64-darwin"
return 0
}

0 comments on commit 452ec9e

Please sign in to comment.