Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Expeditor configuration for updating CHANGELOG.md #1718

Merged
merged 3 commits into from
May 2, 2022

Conversation

sajjaphani
Copy link
Contributor

Expeditor configuration for updating CHANGELOG.md

Signed-off-by: Phani Sajja [email protected]

@sajjaphani sajjaphani requested a review from mwrock as a code owner March 15, 2022 06:01
@mwrock
Copy link
Contributor

mwrock commented Mar 16, 2022

My concern here is that the VERSION 2022-02-10 would be less than our current versions on bldr which are 9xxx. If we are going to start a new version scheme its going to have to be later than what is in stable now. While it feels terrible, maybe having VERSION be 12000 is what we have to start with. In any case we will need to update our plan files as well to use VERSION instead of git log. I'm not certain, but we may also need to setup expeditor channels, as proposed in #1707 so that changes get properly rolled up after a promotion.

@mwrock
Copy link
Contributor

mwrock commented Mar 16, 2022

so actually now that I think of it, maybe what you are getting at here is maintaining VERSION simply for changelog purposes. At least for now that might be the best approach. I'm not sure how/if that will work with the changelog automation but its probably worth merging this to find out. It can't hurt anything.

@@ -37,4 +44,6 @@ subscriptions:

- workload: staged_workload_released:{{agent_id}}:release_staging:*
actions:
- built_in:bump_version
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder how this is going to work with the date format? Maybe we shouldn't have expeditor auto bump and only we bump the version prior to release?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the behavior may be undefined here as we do not have a semantic version in the VERSION file.
What is the result of removing the action: built_in:bump_version. Is it going to add an entry into the change log and use the version specified in the VERSION file?

We can bump the version on the release date if the above works for us.

The other option is to start using the semantic version 1.0.0 for the builder.

@sajjaphani
Copy link
Contributor Author

sajjaphani commented Mar 17, 2022

so actually now that I think of it, maybe what you are getting at here is maintaining VERSION simply for changelog purposes. At least for now that might be the best approach. I'm not sure how/if that will work with the changelog automation but its probably worth merging this to find out. It can't hurt anything.

We started publishing the builder changes based on the date. I think it may not be a bad idea to start the builder with semantic versioning 1.0.0 and let expeditor bump the version.

@mwrock
Copy link
Contributor

mwrock commented Mar 18, 2022

I kind of like the date more. If we move to semantic versioning, I think we need to make that change to the packages as well and not just the change log. In which case we need to start with 12000.0 which seems weird. I'm not sure exactly how the changelog automation will behabe if we remove built_in:bump_version but I think that will keep it from trying to create a 2022-02-23.1 and so on. We'll probably have to merge something and experiment but I'm hoping that when we want to release, we just change the VERSION to the new data and then expeditor rolls up the changelog correctly. That could be wishful thinking (most of my thinking really).

Signed-off-by: Phani Sajja <[email protected]>
VERSION Outdated
@@ -0,0 +1 @@
2022-02-10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should make this 20220210 so that latest will honor these versions. I think (not 100%) thta 2022-02-10 would not be latest

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still, that is the last time we released the builder.

Signed-off-by: Phani Sajja <[email protected]>
@sajjaphani sajjaphani merged commit d363aa3 into main May 2, 2022
@sajjaphani sajjaphani deleted the psajja/expeditor-changelog branch May 2, 2022 16:05
chef-expeditor bot pushed a commit that referenced this pull request May 2, 2022
Obvious fix; these changes are the result of automation not creative thinking.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants