-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Expeditor configuration for updating CHANGELOG.md #1718
Conversation
Signed-off-by: Phani Sajja <[email protected]>
My concern here is that the |
so actually now that I think of it, maybe what you are getting at here is maintaining VERSION simply for changelog purposes. At least for now that might be the best approach. I'm not sure how/if that will work with the changelog automation but its probably worth merging this to find out. It can't hurt anything. |
.expeditor/config.yml
Outdated
@@ -37,4 +44,6 @@ subscriptions: | |||
|
|||
- workload: staged_workload_released:{{agent_id}}:release_staging:* | |||
actions: | |||
- built_in:bump_version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder how this is going to work with the date format? Maybe we shouldn't have expeditor auto bump and only we bump the version prior to release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, the behavior may be undefined here as we do not have a semantic version in the VERSION file.
What is the result of removing the action: built_in:bump_version. Is it going to add an entry into the change log and use the version specified in the VERSION file?
We can bump the version on the release date if the above works for us.
The other option is to start using the semantic version 1.0.0 for the builder.
We started publishing the builder changes based on the date. I think it may not be a bad idea to start the builder with semantic versioning 1.0.0 and let expeditor bump the version. |
I kind of like the date more. If we move to semantic versioning, I think we need to make that change to the packages as well and not just the change log. In which case we need to start with 12000.0 which seems weird. I'm not sure exactly how the changelog automation will behabe if we remove |
Signed-off-by: Phani Sajja <[email protected]>
VERSION
Outdated
@@ -0,0 +1 @@ | |||
2022-02-10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should make this 20220210
so that latest
will honor these versions. I think (not 100%) thta 2022-02-10
would not be latest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still, that is the last time we released the builder.
Signed-off-by: Phani Sajja <[email protected]>
Obvious fix; these changes are the result of automation not creative thinking.
Expeditor configuration for updating CHANGELOG.md
Signed-off-by: Phani Sajja [email protected]