Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename the variable 'weekendDays' to 'weekDays' #313

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

jaehunn
Copy link
Contributor

@jaehunn jaehunn commented Jan 13, 2024

No description provided.

@jaehunn jaehunn requested a review from JaeYeopHan as a code owner January 13, 2024 03:25
Copy link

netlify bot commented Jan 13, 2024

👷 Deploy Preview for h6s-react-examples processing.

Name Link
🔨 Latest commit 406da04
🔍 Latest deploy log https://app.netlify.com/sites/h6s-react-examples/deploys/65a20290286ee8000861204e

Copy link

netlify bot commented Jan 13, 2024

Deploy Preview for h6s-react-examples canceled.

Name Link
🔨 Latest commit 406da04
🔍 Latest deploy log https://app.netlify.com/sites/h6s-react-examples/deploys/65a20290286ee8000861204e

Copy link

netlify bot commented Jan 13, 2024

Deploy Preview for storybook-h6s ready!

Name Link
🔨 Latest commit 406da04
🔍 Latest deploy log https://app.netlify.com/sites/storybook-h6s/deploys/65a20290b3062900080e88f5
😎 Deploy Preview https://deploy-preview-313--storybook-h6s.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 13, 2024

Deploy Preview for h6s-dev canceled.

Name Link
🔨 Latest commit 406da04
🔍 Latest deploy log https://app.netlify.com/sites/h6s-dev/deploys/65a202901c4ee0000806fc1d

@JaeYeopHan
Copy link
Collaborator

JaeYeopHan commented Jan 15, 2024

why is this change necessary?

@jaehunn
Copy link
Contributor Author

jaehunn commented Jan 15, 2024

sorry, I didn't write an explanation why I changed it.

my understanding is that 'weekendDays' mean to Saturday and Sunday .
the usage (useCalendar.tsx line.33) showed that it was already using 'weekDays' the number of days in a week.

@jaehunn
Copy link
Contributor Author

jaehunn commented Jan 15, 2024

please le me know, if i my understanding is not the same with the intent of the code. thank you

@JaeYeopHan
Copy link
Collaborator

my understanding is that 'weekendDays' mean to Saturday and Sunday .

omg you're right!!

@JaeYeopHan JaeYeopHan merged commit d20ab0a into h6s-dev:main Jan 15, 2024
8 checks passed
@JaeYeopHan
Copy link
Collaborator

@all-contributors please add @jaehunn for maintenance

Copy link
Contributor

@JaeYeopHan

I've put up a pull request to add @jaehunn! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants