Batch import image files #57
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @kk-maker636! Cool that you want to contribute to H5P. I am not sure though if this pull request meets what was asked for in the issue that you linked to. The idea there was to be able to upload multiple image files to CoursePresentation that would then automatically be used as background images for slides. Your code would do something very different (and doesn't follow the H5P coding style guidelines). |
|
This library is for displaying a single image, so it seems this should be solved in another way. Therefore I am closing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a request on the H5P Course Presentation to batch import images:
As an author, I can batch import any png or jpg image instead of uploading them one by one.
Accompanied by h5p/h5p-course-presentation#175