Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BREAKING] Refactor NimBLEServer #763

Merged
merged 3 commits into from
Nov 29, 2024
Merged

[BREAKING] Refactor NimBLEServer #763

merged 3 commits into from
Nov 29, 2024

Commits on Nov 28, 2024

  1. [BREAKING] Refactor NimBLEServer 

    * General code cleanup
* `NimBLEServerCallbacks::onMTUChanged` renamed to `NimBLEServerCallbacks::onMTUChange` to be consistent with the client callback.
* `NimBLEServer::getPeerIDInfo` renamed to `NimBLEServer::getPeerInfoByHandle` to better describe it's use.
* Use a std::array to store client connection handles instead of std::vector to reduce memory allocation.
* `NimBLEServer::disconnect` now returns `bool`, true = success,  instead of `int` to be consistent with the rest of the library.
    @h2zero
    h2zero committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    c4ff63c View commit details
    Browse the repository at this point in the history

  2. Remove characteristic subscription tracking. 

    Removes tracking of client characteristic subscription status from `NimBLEServer` and `NimBLECharacteristic` and instead uses
the functions and tracking in the host stack.

* `NimBLECharacteristic::notify` and `NimBLECharacteristic::indicate` now return a `bool`, true = success.
    @h2zero
    h2zero committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    121a1f2 View commit details
    Browse the repository at this point in the history

  3. Refactor service changed handling 

    This makes the services changes notification more accurate by waiting until the changes have taken effect and the server re-started before indicating the change.
    @h2zero
    h2zero committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    1c88a13 View commit details
    Browse the repository at this point in the history