Refactor NimBLEExtAdvertising #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h2zero
force-pushed
the
refactor-extadvertising
branch
5 times, most recently
from
d69aa76
to
7a1d059
Compare
* General code cleanup * `NimBLEExtAdvertisement` : All functions that set data now return `bool`, true = success. * Added new method, `NimBLEExtAdvertisement::removeData`, which will remove the data of the specified type from the advertisement. * Added new method, `NimBLEExtAdvertisement::addServiceUUID`, which will append to the service uuids advertised. * Added new method, `NimBLEExtAdvertisement::removeServiceUUID`, which will remove the service from the uuids advertised. * Added new method, `NimBLEExtAdvertisement::removeServices`, which will remove all service uuids advertised. * Added overloads for `NimBLEExtAdvertisement::setServiceData` with the parameters `const NimBLEUUID& uuid, const uint8_t* data, size_t length` and `const NimBLEUUID& uuid, const std::vector<uint8_t>& data`. * Added new method, `NimBLEExtAdvertisement::getDataLocation`, which returns the location in the advertisment data of the type requested in parameter `uint8_t type`. * Added new method, `toString` which returns a Hex string representation of the advertisement data.
* Added new method `NimBLEScan::setScanPhy` to enable/disable the PHY's to scan on. * Added new method `NimBLEScan::setScanPeriod` which will allow for setting a scan restart timer in the controller. * Updated `NimBLEScan::start` to allow the command to be sent with updated parameters if already scanning. * Added extended scan example. * Removed storing and restarting of the scan on host reset as it is more appropriate to call the scanEnded callback instead.
* Added `NimBLEDevice::setDefaultPhy` which will set the default preferred PHY for all connections. * Added `NimBLEClient::updatePhy` to request a PHY change with a peer. * Added `NimBLEClient::getPhy` to read the current connection PHY setting. * Added `NimBLEServer::updatePhy` to request a PHY change with a peer. * Added `NimBLEServer::getPhy` to read the PHY of a peer connection. * Added callbacks: * - `NimBLEClientCallbacks::onPhyUpdate` * - `NimBLEServerCallbacks::onPhyUpdate` Which are called when the PHY update is complete.
h2zero
force-pushed
the
refactor-extadvertising
branch
from
7a1d059
to
fbe20f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NimBLEExtAdvertisement: All functions that set data now returnbool, true = success.NimBLEExtAdvertisement::removeData, which will remove the data of the specified type from the advertisement.NimBLEExtAdvertisement::addServiceUUID, which will append to the service uuids advertised.NimBLEExtAdvertisement::removeServiceUUID, which will remove the service from the uuids advertised.NimBLEExtAdvertisement::removeServices, which will remove all service uuids advertised.NimBLEExtAdvertisement::setServiceDatawith the parametersconst NimBLEUUID& uuid, const uint8_t* data, size_t lengthandconst NimBLEUUID& uuid, const std::vector<uint8_t>& data.NimBLEExtAdvertisement::getDataLocation, which returns the location in the advertisment data of the type requested in parameteruint8_t type.toStringwhich returns a Hex string representation of the advertisement data.NimBLEScan::setScanPhyto enable/disable the PHY's to scan on.NimBLEScan::setScanPeriodwhich will allow for setting a scan restart timer in the controller.NimBLEScan::startto allow the command to be sent with updated parameters if already scanning.NimBLEDevice::setDefaultPhywhich will set the default preferred PHY for all connections.NimBLEClient::updatePhyto request a PHY change with a peer.NimBLEClient::getPhyto read the current connection PHY setting.NimBLEServer::updatePhyto request a PHY change with a peer.NimBLEServer::getPhyto read the PHY of a peer connection.NimBLEClientCallbacks::onPhyUpdateNimBLEServerCallbacks::onPhyUpdateWhich are called when the PHY update is complete.