Merge pull request #278 from h2oai/hotfix-STEAM-623

Files issue writing zip files

ReleaseNotes.md

@@ -10,12 +10,16 @@ If you're an Open Source community member, you can contact H2O using one of the
 - Send an e-mail message directly to <a href="mailto:[email protected]">[email protected]</a>
 - Ask your question on the [H2O Community](https://community.h2o.ai/spaces/540/index.html) site (create an account if necessary)
 
+## v1.1.6 Changes
+
+- [STEAM-623] Fixes a bug that was preventing uploads from working correctly.
+
 ## v1.1.5 Changes
 
 - [STEAM-613] The ``./steam add engine`` command has been replaced with ``./steam upload engine``. 
 - [STEAM-604] When adding clusters to Steam, node sizes are now only specified in GB.
-- [STEAM-619] Adds a confirmation dialog on deletion of a cluster
-- [STEAM-601] Optional ability to supply Python dependencies for Anaconda
+- [STEAM-619] Adds a confirmation dialog on deletion of a cluster.
+- [STEAM-601] Optional ability to supply Python dependencies for Anaconda.
 
 ## v1.1.4 Changes
 

docs/conf.py

@@ -63,7 +63,7 @@
 # built documents.
 #
 # The short X.Y version.
-version = "Steam 1.1.5"
+version = "Steam 1.1.6"
 
 # This commented out code is how the version is displayed in H2O.
 #if os.path.exists("project_version"):

etc/docker/centos-standalone/Dockerfile

@@ -1,6 +1,6 @@
 FROM centos:6.8
 
-MAINTAINER H2O.ai version: 1.1.5
+MAINTAINER H2O.ai version: 1.1.6
 
 WORKDIR /steam
 

etc/docker/hadoop/Dockerfile

@@ -3,7 +3,7 @@ MAINTAINER H2O.ai
 
 USER root
 
-ENV STEAM_VERSION 1.1.5
+ENV STEAM_VERSION 1.1.6
 ENV PATH /steam/steam-${STEAM_VERSION}-linux-amd64:$PATH
 ENV PATH $PATH:/usr/local/hadoop/bin
 

etc/docker/standalone/Dockerfile

@@ -1,6 +1,6 @@
 FROM ubuntu:latest
 
-MAINTAINER H2O.ai version: 1.1.5
+MAINTAINER H2O.ai version: 1.1.6
 
 WORKDIR /steam
 

gui/package.json

@@ -1,6 +1,6 @@
 {
   "name": "steam",
-  "version": "1.1.5",
+  "version": "1.1.6",
   "description": "",
   "main": "src/main.tsx",
   "dependencies": {

master/upload.go

@@ -134,14 +134,17 @@ func (s *UploadHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	dst, err := os.OpenFile(dstPath, os.O_CREATE|os.O_TRUNC, fs.FilePerm)
+	dst, err := os.OpenFile(dstPath, os.O_WRONLY|os.O_CREATE|os.O_TRUNC, fs.FilePerm)
 	if err != nil {
 		log.Println("Upload file open operation failed:", err)
 		http.Error(w, fmt.Sprintf("Error writing uploaded file to disk: %s", err), http.StatusInternalServerError)
 		return
 	}
 	defer dst.Close()
-	io.Copy(dst, src)
+	if _, err := io.Copy(dst, src); err != nil {
+		log.Println("Error writing to destination:", err)
+		http.Error(w, fmt.Sprintf("Error writing zip file: %s", err), http.StatusInternalServerError)
+	}
 
 	switch typ {
 	case fs.KindEngine: