fix entering hot loop if app opens a stream before the handshake is complete (amends #551) #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omplete. H2O opens the HTTP/3 control stream when the connection is created. As that happens before the peer grants any stream credit, QUICLY_PENDING_FLOW_OTHERS_BITgets set, and that leads to `quicly_get_first_timeout` return zero whenever there is space in CWND. But because write keys for the application packet number space is unavailable, `quicly_send` cannot make progress. Hence the hot loop. This PR fixes `quicly_get_first_timeout`. The function no longer returns `0` (indicating now) when the write keys for the application packet number space is available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
H2O opens the HTTP/3 control stream when the connection is created. As that happens before the peer grants any stream credit, QUICLY_PENDING_FLOW_OTHERS_BITgets set, and that leads to
quicly_get_first_timeoutreturn zero whenever there is space in CWND.But because write keys for the application packet number space is unavailable,
quicly_sendcannot make progress.Hence the hot loop.
This PR fixes
quicly_get_first_timeout. The function no longer returns0(indicating now) when the write keys for the application packet number space is available.Amends #551.