Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for bower.json #17

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Support for bower.json #17

wants to merge 3 commits into from

Conversation

manoswerts
Copy link

Also tuned down verbosity.

Mano Swerts added 3 commits May 12, 2013 00:12
Read bower.js if no component.js exists
@mitermayer
Copy link
Contributor

I think the if check that you added is unnecessary, but instead of using an if statement you could using an assignment like:

Var json = checkfileexistfunc ? readfile : {}

@mitermayer
Copy link
Contributor

Since we are checking for many files existances and rreading their content I think that could have own facade function wrapper.

@manoswerts
Copy link
Author

You're right. The code could be written more concise or extracted into a separate object / function. Quick late night contributing to make a use case work does not always result in the best code. I should take more care the next time.
I will make the change in a couple of days.

I also noticed I accidentally started contributing on master instead of develop. That's ok?

@mitermayer
Copy link
Contributor

this is great adition i hope it gets merged soon

@gyllstromk
Copy link
Owner

bower.json is in the develop branch. Does it work for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants