[Test] GenerateColumnDescriptions testing and some refactoring #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing Groq API responses using httpmock
Was missing the wg.Wait() for the API calls goroutine making the Groq API calls in GenerateColumnDescriptions
… without dbt profile Paths for DuckDB are absolute when using a dbt profile, but relative to the pwd when entering config manually. The test now accounts for this dynamically instead of hardcoding the local pwd.
Had an entire sentence italicized, this cuts down unnecessary words and use italics for emphasis on key words rather than a whole sentence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Venturing into the bold new world of API call mocking this morning, using httpmock to mock the Groq API calls required in GenerateColumnDescriptions. Next stop: mocking database calls! The test caught that there was a missing
wg.Wait()call.Also does some very minor refactoring to wrap the
WriteYAMLandWriteStagingModelscalls inmain.gowith aWriteFilesfunction to improve the simplicity and readability ofmain.go.