Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make request module compatible with python3 #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make request module compatible with python3 #21

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 7, 2016

The tricky parts is urllib differences, the easiest solution is to
always use 'future' package. Note: this can be dropped once
compatibility with python2 is no longer required.

Notice: I have not done extensive testing with python2.

The tricky parts is urllib differences, the easiest solution is to
always use 'future' package. Note: this can be dropped once
compatibility with python2 is no longer required.
@@ -2,7 +2,11 @@
import argparse
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't forget to (at least) add from __future__ import print_function. I'd add as well unicode_literals.

@guyzmo
Copy link
Owner

guyzmo commented Dec 7, 2016

I'm ok to switch to requests, when I wrote this code I did not know about it (and chances are it did not exist, or it was too immature to be used).

As I'm not much an user of this project anymore, I'm always happy to drop py2 support on it. But then, we need to make sure that all possible projects depending on this library don't get upgraded by pip to a non-py2 compatible version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant