TR-12632: Cassandra Depreciation for Server - Existing Customers: Update upgradeTestRail.sh #70
Conversation
shubham-kickdrumtech
changed the base branch from
feature/TR-12627
to
master
shubham-kickdrumtech
changed the base branch from
master
to
feature/TR-12627
| @@ -44,13 +46,20 @@ else | |||
| fi | |||
| fi | |||
|
|
|||
|
|
|||
| if [ "$(printf '%s\n' "$version" "$cassandraDeprecationVersion" | sort -V | head -n1)" == "$version" ] && [ "$version" != "$cassandraDeprecationVersion" ]; then | |||
There was a problem hiding this comment.
aren't we checking if cassandra deprecation version is lower than 9?
There was a problem hiding this comment.
@gneb Essentially, we are verifying that if the app version is more than or equal to 9, then cassandra deprecation will be applied;For all the below version, a cassandra image will be created.
Please take note that once the version is stable, we will update this number from 9 to the appropriate value.
There was a problem hiding this comment.
ok, also we need to be sure that it will work for any combinations, like 9.0.0, 9.0, 9, 9.0.1, 9.5, 9.5.0, etc... @shubham-kickdrumtech
There was a problem hiding this comment.
@gneb It was failing for version 9.0 and 9 which we have fixed and pushed the changes, thanks for pointing this, please find the attachments:
| @@ -4,6 +4,8 @@ timeStamp=$(date "+%Y.%m.%d-%H.%M.%S") | |||
| dbFolder=_mysql | |||
| optFolder=_opt | |||
| confFolder=_config | |||
| cassandraDeprecationVersion="9.0.0" | |||
There was a problem hiding this comment.
@shubham-kickdrumtech I'd consider adding a comment before this line, so that it will be clear this version number will need to be updated.
CC: @gneb
There was a problem hiding this comment.
@damianoferrari I have added the comment.
Ticket Description:
https://gurock.atlassian.net/browse/TR-12632