Limit finalized header gap (Snowfork#1156)

* construct finalized update * extract interfaces for tests * mock data and tests * adds db store * completes db store * test works * cleanup and fixes * cleanup and fixes * tests * relayer progress * finish tests * formatting * move the interim finalized header check * fix ci * fix ci * adds working dir * go mod download * version * wrap go version * update * add gopath to bin * install sszgen * missing go install * remove build * skip utility tests * remove unused file * remove test line * rename method * refactor method * Fix compile error and breaking tests * clean up imports * fix duplicate import --------- Co-authored-by: claravanstaden <Cats 4 life!> Co-authored-by: ron <[email protected]>
guqicun · Mar 21, 2024 · 8a51ac9 · 8a51ac9
1 parent 77652c1
commit 8a51ac9
Show file tree

Hide file tree

Showing 43 changed files with 1,862 additions and 317 deletions.
diff --git a/.github/workflows/relayer.yml b/.github/workflows/relayer.yml
@@ -0,0 +1,39 @@
+name: relayer
+
+on:
+  push:
+    paths:
+      - "relayer/**"
+    branches:
+      - main
+  pull_request:
+    paths:
+      - "relayer/**"
+
+jobs:
+  build:
+    runs-on: snowbridge-runner
+    timeout-minutes: 15
+    steps:
+      - uses: actions/checkout@v1
+        with:
+          fetch-depth: 2
+
+      - name: setup go
+        uses: actions/checkout@v4
+        with:
+          go-version: '^1.20.1'
+
+      - name: check go version
+        run: go version
+
+      - name: install dependencies
+        working-directory: relayer
+        run: go mod download
+
+      - name: Add gopath to bin
+        run: echo "$HOME/go/bin" >> $GITHUB_PATH
+
+      - name: test
+        working-directory: relayer
+        run: go test -v ./...
diff --git a/.gitignore b/.gitignore
@@ -28,6 +28,9 @@ parachain/build_rs_cov.profraw
 compiler_config.json
 contracts/beefy-state.json
 
+# beacon states generate by relayer
+states/
+
 go/
 gocache/
 go.work*

diff --git a/relayer/chain/ethereum/message_test.go b/relayer/chain/ethereum/message_test.go
@@ -60,8 +60,7 @@ func TestMessage_Proof(t *testing.T) {
 	assert.Nil(t, err)
 	assert.NotNil(t, msg)
 
-	assert.Equal(t, block.Hash().Hex(), msg.Proof.BlockHash.Hex())
-	key, err := rlp.EncodeToBytes(uint(msg.Proof.TxIndex))
+	key, err := rlp.EncodeToBytes(uint(5))
 	if err != nil {
 		panic(err)
 	}

diff --git a/relayer/chain/parachain/connection_test.go b/relayer/chain/parachain/connection_test.go
@@ -12,6 +12,8 @@ import (
 )
 
 func TestConnect(t *testing.T) {
+	t.Skip("skip testing utility test")
+
 	conn := parachain.NewConnection("ws://127.0.0.1:11144/", sr25519.Alice().AsKeyringPair())
 	err := conn.Connect(context.Background())
 	if err != nil {

diff --git a/relayer/chain/parachain/writer.go b/relayer/chain/parachain/writer.go
@@ -5,15 +5,29 @@ import (
 	"fmt"
 	"sync"
 
-	"github.com/ethereum/go-ethereum/common"
-	log "github.com/sirupsen/logrus"
 	"github.com/snowfork/go-substrate-rpc-client/v4/rpc/author"
 	"github.com/snowfork/go-substrate-rpc-client/v4/types"
 	"github.com/snowfork/snowbridge/relayer/relays/beacon/header/syncer/scale"
 	"github.com/snowfork/snowbridge/relayer/relays/beacon/state"
+
+	"github.com/ethereum/go-ethereum/common"
+	log "github.com/sirupsen/logrus"
 	"golang.org/x/sync/errgroup"
 )
 
+type ChainWriter interface {
+	BatchCall(ctx context.Context, extrinsic string, calls []interface{}) error
+	WriteToParachainAndRateLimit(ctx context.Context, extrinsicName string, payload ...interface{}) error
+	WriteToParachainAndWatch(ctx context.Context, extrinsicName string, payload ...interface{}) error
+	GetLastFinalizedHeaderState() (state.FinalizedHeader, error)
+	GetFinalizedStateByStorageKey(key string) (scale.BeaconState, error)
+	GetLastBasicChannelBlockNumber() (uint64, error)
+	GetLastBasicChannelNonceByAddress(address common.Address) (uint64, error)
+	GetFinalizedHeaderStateByBlockRoot(blockRoot types.H256) (state.FinalizedHeader, error)
+	GetLastFinalizedStateIndex() (types.U32, error)
+	GetFinalizedBeaconRootByIndex(index uint32) (types.H256, error)
+}
+
 type ParachainWriter struct {
 	conn                 *Connection
 	nonce                uint32
@@ -133,105 +147,6 @@ func (wr *ParachainWriter) WriteToParachainAndWatch(ctx context.Context, extrins
 	}
 }
 
-func (wr *ParachainWriter) writeToParachain(ctx context.Context, extrinsicName string, payload ...interface{}) (*author.ExtrinsicStatusSubscription, error) {
-	extI, err := wr.prepExtrinstic(ctx, extrinsicName, payload...)
-	if err != nil {
-		return nil, err
-	}
-
-	sub, err := wr.conn.API().RPC.Author.SubmitAndWatchExtrinsic(*extI)
-	if err != nil {
-		return nil, err
-	}
-
-	return sub, nil
-}
-
-func (wr *ParachainWriter) queryAccountNonce() (uint32, error) {
-	key, err := types.CreateStorageKey(wr.conn.Metadata(), "System", "Account", wr.conn.Keypair().PublicKey, nil)
-	if err != nil {
-		return 0, err
-	}
-
-	var accountInfo types.AccountInfo
-	ok, err := wr.conn.API().RPC.State.GetStorageLatest(key, &accountInfo)
-	if err != nil {
-		return 0, err
-	}
-	if !ok {
-		return 0, fmt.Errorf("no account info found for %s", wr.conn.Keypair().URI)
-	}
-
-	return uint32(accountInfo.Nonce), nil
-}
-
-func (wr *ParachainWriter) prepExtrinstic(ctx context.Context, extrinsicName string, payload ...interface{}) (*types.Extrinsic, error) {
-	meta, err := wr.conn.API().RPC.State.GetMetadataLatest()
-	if err != nil {
-		return nil, err
-	}
-
-	c, err := types.NewCall(meta, extrinsicName, payload...)
-	if err != nil {
-		return nil, err
-	}
-
-	latestHash, err := wr.conn.API().RPC.Chain.GetFinalizedHead()
-	if err != nil {
-		return nil, err
-	}
-
-	latestBlock, err := wr.conn.API().RPC.Chain.GetBlock(latestHash)
-	if err != nil {
-		return nil, err
-	}
-
-	ext := types.NewExtrinsic(c)
-	era := NewMortalEra(uint64(latestBlock.Block.Header.Number))
-
-	genesisHash, err := wr.conn.API().RPC.Chain.GetBlockHash(0)
-	if err != nil {
-		return nil, err
-	}
-
-	rv, err := wr.conn.API().RPC.State.GetRuntimeVersionLatest()
-	if err != nil {
-		return nil, err
-	}
-
-	o := types.SignatureOptions{
-		BlockHash:          latestHash,
-		Era:                era,
-		GenesisHash:        genesisHash,
-		Nonce:              types.NewUCompactFromUInt(uint64(wr.nonce)),
-		SpecVersion:        rv.SpecVersion,
-		Tip:                types.NewUCompactFromUInt(0),
-		TransactionVersion: rv.TransactionVersion,
-	}
-
-	extI := ext
-
-	err = extI.Sign(*wr.conn.Keypair(), o)
-	if err != nil {
-		return nil, err
-	}
-
-	return &extI, nil
-}
-
-func (wr *ParachainWriter) prepCall(extrinsicName string, payload ...interface{}) (*types.Call, error) {
-	meta, err := wr.conn.API().RPC.State.GetMetadataLatest()
-	if err != nil {
-		return nil, err
-	}
-
-	c, err := types.NewCall(meta, extrinsicName, payload...)
-	if err != nil {
-		return nil, err
-	}
-	return &c, nil
-}
-
 func (wr *ParachainWriter) GetLastBasicChannelBlockNumber() (uint64, error) {
 	return wr.getNumberFromParachain("EthereumInboundQueue", "LatestVerifiedBlockNumber")
 }
@@ -331,6 +246,105 @@ func (wr *ParachainWriter) GetFinalizedHeaderStateByBlockRoot(blockRoot types.H2
 	}, nil
 }
 
+func (wr *ParachainWriter) writeToParachain(ctx context.Context, extrinsicName string, payload ...interface{}) (*author.ExtrinsicStatusSubscription, error) {
+	extI, err := wr.prepExtrinstic(ctx, extrinsicName, payload...)
+	if err != nil {
+		return nil, err
+	}
+
+	sub, err := wr.conn.API().RPC.Author.SubmitAndWatchExtrinsic(*extI)
+	if err != nil {
+		return nil, err
+	}
+
+	return sub, nil
+}
+
+func (wr *ParachainWriter) queryAccountNonce() (uint32, error) {
+	key, err := types.CreateStorageKey(wr.conn.Metadata(), "System", "Account", wr.conn.Keypair().PublicKey, nil)
+	if err != nil {
+		return 0, err
+	}
+
+	var accountInfo types.AccountInfo
+	ok, err := wr.conn.API().RPC.State.GetStorageLatest(key, &accountInfo)
+	if err != nil {
+		return 0, err
+	}
+	if !ok {
+		return 0, fmt.Errorf("no account info found for %s", wr.conn.Keypair().URI)
+	}
+
+	return uint32(accountInfo.Nonce), nil
+}
+
+func (wr *ParachainWriter) prepExtrinstic(ctx context.Context, extrinsicName string, payload ...interface{}) (*types.Extrinsic, error) {
+	meta, err := wr.conn.API().RPC.State.GetMetadataLatest()
+	if err != nil {
+		return nil, err
+	}
+
+	c, err := types.NewCall(meta, extrinsicName, payload...)
+	if err != nil {
+		return nil, err
+	}
+
+	latestHash, err := wr.conn.API().RPC.Chain.GetFinalizedHead()
+	if err != nil {
+		return nil, err
+	}
+
+	latestBlock, err := wr.conn.API().RPC.Chain.GetBlock(latestHash)
+	if err != nil {
+		return nil, err
+	}
+
+	ext := types.NewExtrinsic(c)
+	era := NewMortalEra(uint64(latestBlock.Block.Header.Number))
+
+	genesisHash, err := wr.conn.API().RPC.Chain.GetBlockHash(0)
+	if err != nil {
+		return nil, err
+	}
+
+	rv, err := wr.conn.API().RPC.State.GetRuntimeVersionLatest()
+	if err != nil {
+		return nil, err
+	}
+
+	o := types.SignatureOptions{
+		BlockHash:          latestHash,
+		Era:                era,
+		GenesisHash:        genesisHash,
+		Nonce:              types.NewUCompactFromUInt(uint64(wr.nonce)),
+		SpecVersion:        rv.SpecVersion,
+		Tip:                types.NewUCompactFromUInt(0),
+		TransactionVersion: rv.TransactionVersion,
+	}
+
+	extI := ext
+
+	err = extI.Sign(*wr.conn.Keypair(), o)
+	if err != nil {
+		return nil, err
+	}
+
+	return &extI, nil
+}
+
+func (wr *ParachainWriter) prepCall(extrinsicName string, payload ...interface{}) (*types.Call, error) {
+	meta, err := wr.conn.API().RPC.State.GetMetadataLatest()
+	if err != nil {
+		return nil, err
+	}
+
+	c, err := types.NewCall(meta, extrinsicName, payload...)
+	if err != nil {
+		return nil, err
+	}
+	return &c, nil
+}
+
 func (wr *ParachainWriter) getHashFromParachain(pallet, storage string) (common.Hash, error) {
 	key, err := types.CreateStorageKey(wr.conn.Metadata(), pallet, storage, nil, nil)
 	if err != nil {
@@ -394,36 +408,3 @@ func (wr *ParachainWriter) GetFinalizedBeaconRootByIndex(index uint32) (types.H2
 
 	return beaconRoot, nil
 }
-
-func (wr *ParachainWriter) FindCheckPointBackward(slot uint64) (state.FinalizedHeader, error) {
-	var beaconState state.FinalizedHeader
-	lastIndex, err := wr.GetLastFinalizedStateIndex()
-	if err != nil {
-		return beaconState, fmt.Errorf("GetLastFinalizedStateIndex error: %w", err)
-	}
-	startIndex := uint32(lastIndex)
-	endIndex := uint32(0)
-	if lastIndex > 256 {
-		endIndex = endIndex - 256
-	}
-	for index := startIndex; index >= endIndex; index-- {
-		beaconRoot, err := wr.GetFinalizedBeaconRootByIndex(index)
-		if err != nil {
-			return beaconState, fmt.Errorf("GetFinalizedBeaconRootByIndex %d, error: %w", index, err)
-		}
-		beaconState, err = wr.GetFinalizedHeaderStateByBlockRoot(beaconRoot)
-		if err != nil {
-			return beaconState, fmt.Errorf("GetFinalizedHeaderStateByBlockRoot %s, error: %w", beaconRoot.Hex(), err)
-		}
-		if beaconState.BeaconSlot < slot {
-			break
-		}
-		if beaconState.BeaconSlot > slot && beaconState.BeaconSlot < slot+8192 {
-			break
-		}
-	}
-	if beaconState.BeaconSlot > slot && beaconState.BeaconSlot < slot+8192 {
-		return beaconState, nil
-	}
-	return beaconState, fmt.Errorf("Can't find checkpoint on chain for slot %d", slot)
-}
diff --git a/relayer/chain/relaychain/connection_test.go b/relayer/chain/relaychain/connection_test.go
@@ -11,6 +11,8 @@ import (
 )
 
 func TestConnect(t *testing.T) {
+	t.Skip("skip testing utility test")
+
 	conn := relaychain.NewConnection("ws://127.0.0.1:9944/")
 	err := conn.Connect(context.Background())
 	if err != nil {