Fixes to target-spec #355
Merged
Fixes to target-spec #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunshowers
force-pushed
the
target-spec-fixes
branch
from
3bb712b to
92d25d5
Compare
For errors parsing custom platforms, we should report the underlying `serde_json` error as a proper diagnostic. I had to deprecate the existing `Deserialize` variant because it didn't carry the input (whoops!)
…rrectly Oof, this is a pretty bad bug -- we weren't deserializing these correctly. Add some spot checks, some snapshot tests, and remove some old `rustc_version` code.
sunshowers
force-pushed
the
target-spec-fixes
branch
from
92d25d5 to
97c1b03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.