[guppy] fix detection for non-lib/proc-macro targets #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As suggested by the samply README.
Rather large speedup:
```
make_package_graph time: [6.8933 ms 6.9152 ms 6.9508 ms]
change: [-5.6342% -5.3294% -4.9152%] (p = 0.00 < 0.05)
Performance has improved.
```
```
make_package_graph time: [7.0567 ms 7.0612 ms 7.0677 ms]
change: [-5.4637% -4.1646% -2.9836%] (p = 0.00 < 0.05)
Performance has improved.
```
sunshowers
force-pushed
the
push-yurtvsspsqyp
branch
from
45ade0e to
05bd940
Compare
This RefCell is a bit convoluted, but it appears to be the fastest approach based on benchmarks. This doesn't appear to cause a statistically significant perf difference for the make_package_graph benchmark. Fixes #157.
sunshowers
force-pushed
the
push-yurtvsspsqyp
branch
from
05bd940 to
b511b05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.