Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update hakari.yml to be more modern + switch to AHashMap #154

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

sunshowers
Copy link
Member

No description provided.

Switch to ahash, which promises to be faster at lookups.

Overall, iteration through the hash map is a bit slower but
`make_package_graph` and other queries are faster.

```

make_package_graph      time:   [6.9865 ms 7.0088 ms 7.0313 ms]
                        change: [-4.0527% -3.5680% -3.1149%] (p = 0.00 < 0.05)
                        Performance has improved.

depends_on              time:   [110.99 µs 111.12 µs 111.27 µs]
                        change: [-12.629% -12.282% -11.952%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
  2 (2.00%) low mild
  3 (3.00%) high mild

depends_on_cache        time:   [92.296 µs 92.522 µs 92.777 µs]
                        change: [-18.680% -18.438% -18.227%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 6 outliers among 100 measurements (6.00%)
  2 (2.00%) low mild
  3 (3.00%) high mild
  1 (1.00%) high severe

into_ids                time:   [164.61 µs 164.74 µs 164.87 µs]
                        change: [-9.3113% -8.9215% -8.5783%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
  2 (2.00%) low mild
  1 (1.00%) high mild
  2 (2.00%) high severe

resolve_package_name    time:   [1.4308 µs 1.4327 µs 1.4351 µs]
                        change: [+12.664% +12.952% +13.227%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) high mild

make_package_name_hashmap
                        time:   [50.083 µs 50.112 µs 50.144 µs]
                        change: [-0.0379% +0.0879% +0.2012%] (p = 0.16 > 0.05)
                        No change in performance detected.
Found 5 outliers among 100 measurements (5.00%)
  3 (3.00%) high mild
  2 (2.00%) high severe

make_cycles             time:   [55.688 µs 55.770 µs 55.871 µs]
                        change: [+6.9990% +7.4064% +7.7971%] (p = 0.00 < 0.05)
                        Performance has regressed.
```
@sunshowers sunshowers merged commit bcb9121 into guppy-rs:main Nov 14, 2023
18 checks passed
@sunshowers sunshowers deleted the push-lorqtktqnunu branch November 14, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant