[guppy] fix issue with dep matching #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 9, 2023
sunshowers
force-pushed
the
push-rrwxxrovyltq
branch
4 times, most recently
from
2e4751f to
9b83ef1
Compare
sunshowers
changed the title
We used to use a heuristic matching algorithm which would check a renamed map first, then check an original map. We know that that was failing to work in a few cases, and we encountered one such case in the wild in nextest-rs/nextest#1090. Fix that through a few different things: 1. Match up the resolved name correctly, using the same algorithm Cargo uses. 2. Use the `dep_kinds` list introduced in Rust 1.41 (see rust-lang/cargo#5583).
These metadata instances are generated with a newer version of Rust, which pulls in `dep_kinds` in the resolve map. That makes matching up requirements more reliable.
sunshowers
force-pushed
the
push-rrwxxrovyltq
branch
from
b08401d to
3e0eb9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make this somewhat less of a hack than it used to be, with the
dep_kindssupport introduced in Rust 1.41.