Skip to content

Commit

Permalink
[target-spec-miette] report serde_json errors properly
Browse files Browse the repository at this point in the history
For errors parsing custom platforms, we should report the underlying
`serde_json` error as a proper diagnostic.

I had to deprecate the existing `Deserialize` variant because it didn't carry
the input (whoops!)
  • Loading branch information
sunshowers committed Dec 22, 2024
1 parent 5670993 commit 8990357
Show file tree
Hide file tree
Showing 17 changed files with 636 additions and 19 deletions.
168 changes: 157 additions & 11 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@ members = [

[workspace.dependencies]
ahash = "0.8.11"
datatest-stable = "0.2.10"
guppy-workspace-hack = "0.1.0"
insta = "1.41.1"
miette = "7.2.0"

[workspace.package]
Expand Down
10 changes: 10 additions & 0 deletions target-spec-miette/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,15 @@ target-spec = { version = "3.2.2", path = "../target-spec" }
miette.workspace = true
guppy-workspace-hack.workspace = true

[dev-dependencies]
datatest-stable.workspace = true
insta.workspace = true
miette = { workspace = true, features = ["fancy"] }
target-spec = { version = "3.2.2", path = "../target-spec", features = ["custom"] }

[lints]
workspace = true

[[test]]
name = "snapshot"
harness = false
Loading

0 comments on commit 8990357

Please sign in to comment.