Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add index to docs samples #291

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RogerHowellDfE
Copy link

I suggest that a useful addition to the tag helper library would be a reference site, where it is possible to see both the rendered HTML component alongside the code (tag helpers) used to generate it.

This draft PR is a stepping stone towards a reference site, introducing a similar index page.

Before I run too far with it, is this kind of docs site something that would be welcomed?

Notes:

  • I have not added any new samples and I have not modified pre-existing examples
    • The code in this PR should dynamically pick up any additional samples that do get added
  • It does not publish it as a review app for now (it must be run locally as currently is the case).
    • I do wonder if we could use wget or similar to pull a copy of the generated HTML pages and host that static HTML on GitHub Pages?
  • I see that there is additional information in the docs/ directory
    • If we were to run with publishing a GitHub pages site, these could be incorporated too?

Screenshot:

image

@gunndabad
Copy link
Owner

Before I run too far with it, is this kind of docs site something that would be welcomed?

Yes, definitely. I'd like to move towards a 'proper' doc site ultimately. I'll have a think about how to split up the tasks around this. https://govuk-components.netlify.app/ is some nice prior art

@sussexrick
Copy link
Contributor

FYI we have partially what you're looking for, though not as comprehensive as you're suggesting. It's not published online so you have to clone our repo and run it.

https://github.com/thepensionsregulator/govuk-frontend-aspnetcore-extensions/blob/develop/docs/aspnet/run-example-application.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants