make default model of a constant class variable (microsoft#1780)

* make default model of a constant class variable * make default model of a constant class variable --------- Co-authored-by: Chi Wang <[email protected]>
gunnarku · Feb 28, 2024 · d35754d · d35754d
1 parent dc89147
commit d35754d
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/autogen/agentchat/contrib/gpt_assistant_agent.py b/autogen/agentchat/contrib/gpt_assistant_agent.py
@@ -21,6 +21,8 @@ class GPTAssistantAgent(ConversableAgent):
     This agent is unique in its reliance on the OpenAI Assistant for state management, differing from other agents like ConversableAgent.
     """
 
+    DEFAULT_MODEL_NAME = "gpt-4-0125-preview"
+
     def __init__(
         self,
         name="GPT Assistant",
@@ -61,16 +63,17 @@ def __init__(
 
         if llm_config is False:
             raise ValueError("llm_config=False is not supported for GPTAssistantAgent.")
-
-        # Use AutoGen OpenAIWrapper to create a client
-        model_name = "gpt-4-0125-preview"
+        # Use AutooGen OpenAIWrapper to create a client
         openai_client_cfg = copy.deepcopy(llm_config)
+        # Use the class variable
+        model_name = GPTAssistantAgent.DEFAULT_MODEL_NAME
+
         # GPTAssistantAgent's azure_deployment param may cause NotFoundError (404) in client.beta.assistants.list()
         # See: https://github.com/microsoft/autogen/pull/1721
         if openai_client_cfg.get("config_list") is not None and len(openai_client_cfg["config_list"]) > 0:
-            model_name = openai_client_cfg["config_list"][0].pop("model", "gpt-4-0125-preview")
+            model_name = openai_client_cfg["config_list"][0].pop("model", GPTAssistantAgent.DEFAULT_MODEL_NAME)
         else:
-            model_name = openai_client_cfg.pop("model", "gpt-4-0125-preview")
+            model_name = openai_client_cfg.pop("model", GPTAssistantAgent.DEFAULT_MODEL_NAME)
 
         logger.warning("OpenAI client config of GPTAssistantAgent(%s) - model: %s", name, model_name)