Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HeatSetNuts from Aliexpress and allow nut size to have more than 3 parts #46

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kcleung
Copy link

@kcleung kcleung commented Jan 26, 2025

As per @gumyr request, I am breaking up the pull request #25 from @infused-kim.

Here is the first part of his pull request. Once this PR is done, I will process the balance of the PR #25

  1. HeatSetNuts from AliExpress
    They can be purchased here: https://www.aliexpress.com/item/1005005220632314.html

It seems like there are multiple stores / brands that sell the same nuts (same dimensions and images). I picked this one, because he has the largest selection, a large amount of sales and was fast to respond in the support chat.

You can also find the spreadsheet I used to edit the data here:
https://docs.google.com/spreadsheets/d/1ZpZ6ltspaA5y2Nw6DH-3abuv4ToLoAWX3zQu_ON2lfs/edit?gid=0#gid=0

  1. Allow nut size to have more than 3 parts
    Some of the AE nuts had the same size thread size and height, but different variations in the outer diameter, such as M2-0.4-H2-D3.2 and M2-0.4-H2-D3.5 (outer diameter 3.2 vs 3.5).

So, I added another - to distinguish between them.

But then the code stopped populating length_size:

if len(size_parts) == 3: self.length_size = size_parts[2]

So, I changed it to allow more than 3 parts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant