Revised square and chamfer thread fixes #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As far as can tell this fixes issue IsoThread external missing single thread loop gumyr#7
Update thread.py to fix internal chamfer bottom fail
Discovered that previous solution of range(2) did not fix all square end cases. Changed range back to 3, added checks to make sure we're only splitting loops that lie on the plane. gumyr#7
Fixing github editor weird tab spacing
This reverts commit b19f9bc.
This reverts commit 477c713.
Previous fix did not fix all edge cases of square cuts. This commit only splits loops if the cut plane falls within their bounding box, and appears to fix all edge cases of square and chamfers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix external square and internal chamfer thread creation in problematic cases.
Ref issues: #7 #9