fix for GHC 9.10 #139
Merged
fix for GHC 9.10 #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- New stack builder for 9.8 - nixpkgs bump - Disabled the "buildFromSdist". I don't remember why this was there and looks like it adds some dependencies to the build. - Removed nix ghc 8.8 support, not in nixpkgs anymore. This is still tested by stack. - Added builder `pyf_910`, works when using `nix develop .#pyf_910`, but build is broken. - Fixed the CPP code for GHC 9.8. I wrongly tested for GHC 9.8 instead of GHC 9.10 in previous support commit for 9.10, resulting in broken 9.8. This is fixed and 9.8 was tested again.
Instead of running one job building ALL GHC version, we use a matrix of job. That's more duplication (compared to just follows what's in flake.nix), but should workaround the limitation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyf_910, works when usingnix develop .#pyf_910, but build is broken.