Adds heading size to design model #1245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sookburt
changed the title
sookburt
changed the title
sookburt
force-pushed
the
skb/add-heading-size-config
branch
from
1063b6c
to
236b88f
Compare
tomrf1
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds an optional font size to the design model which can be picked up by DCR. This allows us to create a tiny banner headline size for banners with no copy.
Trello ticket
How to test
?TBC
How can we measure success?
The ability to add a tiny banner with a headline size of 17px and medium font-weight.
Have we considered potential risks?
Added as optional at this point so that we have time to re-save all banners to pick up the default heading size before potentially making it a compulsory field later.