Add 3 x benefit CTAs to Account Overview for readers with a digital + print sub #1374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjmw
commented
Aug 26, 2024
tjmw
commented
Aug 26, 2024
tjmw
changed the title
…w for people with digital + print subscriptions Renames the existing Feast cta component to DownloadFeastAppCtaWithIcon and introduces a new component DownloadFeastAppCtaWithImage for the account overview screen.
Only the newsletter archive component for now, will apply to the others in a separate commit.
I'd broken this when adding the linear gradient on mobile (but hadn't noticed as this only affects >= tablet).
The width 100% on the container was causing this flex item to be too greedy.
We discussed the best approach as a team, and based on the advice [here] we think there's a good argument that this counts as a launching-off point. [here]: https://www.nngroup.com/articles/new-browser-windows-and-tabs/
Also tweak the css to ensure the image is always anchored to the bottom of the container.
Only an issue if the text ever grows.
tjmw
force-pushed
the
account-overview-benefits-cards
branch
from
a9f1ef2
to
ba5b883
Compare
design amends to the newspaper archive CTA
MaelGNM
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
When a user has a digital+print subscription we now show 3 CTAs on the Account Overview screen for the following benefits:
Images
newspaper archive (hidden behind a feature flag in this pr)