-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group Editions Crosswords By Date #12917
Draft
JamieB-gu
wants to merge
1
commit into
main
Choose a base branch
from
editions-crosswords-by-date
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the shape of the editions crosswords data to be a list of crosswords. Added a `groupByDate` function to divide this up into dates. Added a `CrosswordSelect` component to allow selecting a date and a specific crossword on that date. Added stories and tests for this component. Added a `Crosswords` component that will call the `groupByDate` function, render the `CrosswordSelect` component, and render the selected crossword itself. This for now just renders the first clue of the selected crossword to demonstrate functionality. Added stories and tests for this component.
Size Change: 0 B Total Size: 957 kB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the shape of the editions crosswords data to be a list of crosswords. Added a
groupByDate
function to divide this up into dates. Added aCrosswordSelect
component to allow selecting a date and a specific crossword on that date. Added stories and tests for this component.Added a
Crosswords
component that will call thegroupByDate
function, render theCrosswordSelect
component, and render the selected crossword itself. This for now just renders the first clue of the selected crossword to demonstrate functionality. Added stories and tests for this component.See guardian/frontend#27637 for the corresponding frontend data model change.