Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show ads in right column of football live page #1679

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SiAdcock
Copy link
Contributor

@SiAdcock SiAdcock commented Nov 22, 2024

What does this change?

Allow ads to show in the right column on the football live page.

Why?

8ca948df7b68e24dbd666765e9457f6b

Follow on from #1379

@SiAdcock SiAdcock requested a review from a team as a code owner November 22, 2024 22:29
Copy link

changeset-bot bot commented Nov 22, 2024

🦋 Changeset detected

Latest commit: 541cc95

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@guardian/commercial Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 22, 2024

Ad load time test results

For consented, top-above-nav took on average 5666ms to load.
For consentless, top-above-nav took on average 3357ms to load.

Test conditions:

  • 5mbps download speed
  • 1.5mbps upload speed
  • 150ms latency

@SiAdcock SiAdcock changed the title Show ads on football live page Show ads in right column of football live page Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant