Ensure apiVersion and kind are set for 'list' requests #68
Conversation
lightkube/core/generic_client.py
Outdated
| @@ -192,6 +193,14 @@ def raise_for_status(resp): | |||
| def build_adapter_request(self, br: BasicRequest): | |||
| return self._client.build_request(br.method, br.url, params=br.params, json=br.data, headers=br.headers) | |||
|
|
|||
| def convert_to_resource(self, res: Type[r.Resource], item: dict) -> r.Resource: | |||
| resource_def = res._api_info.resource | |||
| if not issubclass(res, dc_d.DataclassDictMixIn): | |||
There was a problem hiding this comment.
Python's type system doesn't have a great way to provide multiple-inheritance/mixin-based types.
To help the typing system figure things out, I added this issubclass check. It's my understanding that all Type[r.Resource] objects are also DataclassDictMixIn objects - however, if this isn't the case, then this code will not work.
There was a problem hiding this comment.
I think we can just remove this test as it was not present before as well and anyway there is going to be a failure if from_dict is not defined (which should never be the case using standard resources or generic resources).
| extras_require={ | ||
| "dev": [ | ||
| "pytest", | ||
| "pytest-asyncio<0.17.0", |
There was a problem hiding this comment.
It looks like pytest.mark.asyncio has been deprecated at some point (stackoverflow post) - consequently, I had to pin pytest-asyncio to an older version.
These changes address the issue raised here.
Additionally, I:
devextras to the setup.py that installs unit testing dependencies (pytest, pytest-asyncio, respx)