This repository has been archived by the owner on Dec 12, 2023. It is now read-only.
Add RGB_to_YIQ and YIQ_to_RGB #105
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance we could get this merged/reviewed? |
|
Hi @Mattwmaster58, Any reason for not using Scikit-Image conversion? It is already there, vectorised and unit tested. |
|
Sometimes one may prefer a "lighter" library. |
|
That makes sense but then adding new features does not contribute to keep it lightweight. What is the use case for YUV/YIQ? |
|
Understandable. The line between 'lightweight' is sometimes hard to draw. I believe my use case here was a small image comparison library, but I'm not actively working with it at the moment. If you don't want to add this for lightweight/testing concerns I can understand |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by scikit's implementation.