Patch for a proposed fix to issue #4 #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…purposes of modular PRs
|
Needs further testing to ensure correctness. |
|
I am updating the source for the fix to #16. |
|
As noticed by @ceheitsch, the original source produced correct results despite the non-handling of trailing zeros cases. Per request and that feedback, the source has been reverted back to the original on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should integrate the Makefile changes made to the
masterbranch source code to fix issue #4. Note that this PR in part replaces the initial larger merge request documented in issue #3. A separate PR is shortly in order to be created to merge this same patch/bugfix into the development and active testing branch,