adapted the crossbutton icon size #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for wl-orbiter-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for wl-orbiter-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
alexasselin008
approved these changes
Oct 12, 2023
vicky-comeau
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Summary
CrossButton Icon was too big. This is due to the fact that the new design calls for bigger icons in bigger buttons, this is not ideal for close buttons as they look wacky.
What I did
Made sure that CrossButton iconSize is 20px.