Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/typography #4

Merged
merged 21 commits into from
Oct 6, 2023
Merged

Feature/typography #4

merged 21 commits into from
Oct 6, 2023

Conversation

fraincs
Copy link
Contributor

@fraincs fraincs commented Oct 5, 2023

Issue:

Summary

As typography is at the core of all components this PR aims at bringing Hopper typography into Orbiter(font size, font-family, etc)

What I did

  • Added the Hopper fonts.
  • Updated the Heading and Text components to match Hopper Heading and Body.
  • Adapted Orbiter components that uses Header and Text to acknowledge a mismatch in scale.

@netlify
Copy link

netlify bot commented Oct 5, 2023

Deploy Preview for wl-orbiter-website ready!

Name Link
🔨 Latest commit 5597d74
🔍 Latest deploy log https://app.netlify.com/sites/wl-orbiter-website/deploys/65204a9a63b2d000083bc20e
😎 Deploy Preview https://deploy-preview-4--wl-orbiter-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 5, 2023

Deploy Preview for wl-orbiter-storybook ready!

Name Link
🔨 Latest commit 5597d74
🔍 Latest deploy log https://app.netlify.com/sites/wl-orbiter-storybook/deploys/65204a9a2813f30008cbe226
😎 Deploy Preview https://deploy-preview-4--wl-orbiter-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

packages/components/src/typography/src/Heading.css Outdated Show resolved Hide resolved
packages/components/src/typography/src/Heading.css Outdated Show resolved Hide resolved
packages/css/src/font/index.css Outdated Show resolved Hide resolved
@fraincs fraincs marked this pull request as draft October 6, 2023 16:07
@fraincs fraincs marked this pull request as ready for review October 6, 2023 16:58
franckgaudin
franckgaudin previously approved these changes Oct 6, 2023
@fraincs fraincs merged commit 545c7d4 into master Oct 6, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants