-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace element.ref with element.props.ref #207
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for wl-orbiter-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for wl-orbiter-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@tjosepo Thank you. you should probably create a changeset for this |
I'll update the branch with a changeset. I think there are more changes to do before being being ready for React 19, but this one seemed easy to fix quickly. |
tjosepo
force-pushed
the
fix/react-19-access-ref-from-props
branch
from
December 12, 2024 18:55
691abce
to
98511b7
Compare
tjosepo
commented
Dec 12, 2024
tjosepo
force-pushed
the
fix/react-19-access-ref-from-props
branch
from
December 12, 2024 19:19
29a8dc0
to
e424e1e
Compare
alexasselin008
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #206
Summary
React 19 throws this error when using some Orbiter components:
This is caused by doing:
It should now be:
To make it backwards compatible, we can do: