Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow granular CSS imports + Fix bundle peer dependencies #195

Merged
merged 25 commits into from
Nov 22, 2024

Conversation

alexasselin008
Copy link
Member

@alexasselin008 alexasselin008 commented Nov 21, 2024

  • Removed the css and components packages to simplify the structure and avoid bundled exports.
  • Fonts are now properly loaded in Chromatic, making tests a more accurate representation of how users see our components.
  • A detailed documentation article has been written to explain granular CSS imports.
  • Reviewed and updated all stories due to font changes, fixing a few minor pre-existing issues in the process.
  • Orbiter no longer exports @hopper-ui/components CSS, which was causing unnecessary CSS to be included.
  • Removed some unused third-party code and a test suspected of causing issues with Chromatic.

Automating the export list of individual CSS files is an option but seems unnecessary for now. Any updates to Orbiter components will require manual adjustments, though the likelihood of adding new components is low.

Copy link

netlify bot commented Nov 21, 2024

Deploy Preview for wl-orbiter-website ready!

Name Link
🔨 Latest commit 10aa0f1
🔍 Latest deploy log https://app.netlify.com/sites/wl-orbiter-website/deploys/6740e80d97f17b0008292f87
😎 Deploy Preview https://deploy-preview-195--wl-orbiter-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 21, 2024

Deploy Preview for wl-orbiter-storybook ready!

Name Link
🔨 Latest commit 10aa0f1
🔍 Latest deploy log https://app.netlify.com/sites/wl-orbiter-storybook/deploys/6740e80d4aa74a0008aa9edd
😎 Deploy Preview https://deploy-preview-195--wl-orbiter-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

victortrinh2
victortrinh2 previously approved these changes Nov 22, 2024
@alexasselin008 alexasselin008 merged commit 078487c into master Nov 22, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants