Skip to content

Commit

Permalink
Merge pull request #193 from gsoft-inc/feature/ds-462
Browse files Browse the repository at this point in the history
Prevent Listbox & Menu icons/avatars from shrinking - feature/ds-462
  • Loading branch information
fraincs authored Nov 21, 2024
2 parents d1489a5 + c735366 commit 331c01d
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .changeset/witty-peaches-return.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@orbit-ui/transition-components": patch
---

Prevent listbox and menu icon/avatar from shrinking
3 changes: 3 additions & 0 deletions packages/components/src/listbox/src/Listbox.css
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ IMPORTANT: The Listbox component hardcoded a few CSS values to enable dynamic sc
.o-ui-listbox-option-start-icon {
margin-right: var(--hop-space-inline-sm);
grid-area: aside;
flex-shrink: 0;
}

/* OPTION | WITH DESCRIPTION | ICONS | START ICON */
Expand All @@ -111,6 +112,7 @@ IMPORTANT: The Listbox component hardcoded a few CSS values to enable dynamic sc
/* OPTION | ICONS | END ICON */
.o-ui-listbox-option-end-icon {
margin-left: var(--hop-space-inline-sm);
flex-shrink: 0;
}

/* SECTION */
Expand All @@ -130,6 +132,7 @@ IMPORTANT: The Listbox component hardcoded a few CSS values to enable dynamic sc
/* AVATAR */
.o-ui-listbox-option-avatar {
margin-right: var(--hop-space-inline-sm);
flex-shrink: 0;
grid-area: aside;
}

Expand Down
3 changes: 3 additions & 0 deletions packages/components/src/menu/src/Menu.css
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ IMPORTANT: The Menu component hardcoded a few CSS values to enable dynamic scrol

/* ITEM | ICON | START */
.o-ui-menu-item-start-icon {
flex-shrink: 0;
margin-right: var(--hop-space-inline-sm);
grid-row-start: 1;
grid-row-end: 3;
Expand All @@ -83,6 +84,7 @@ IMPORTANT: The Menu component hardcoded a few CSS values to enable dynamic scrol

/* ITEM | ICON | END */
.o-ui-menu-item-end-icon {
flex-shrink: 0;
margin-left: var(--hop-space-inline-sm);
}

Expand Down Expand Up @@ -194,6 +196,7 @@ IMPORTANT: The Menu component hardcoded a few CSS values to enable dynamic scrol
.o-ui-menu-item-option-avatar {
margin-right: var(--hop-space-inline-sm);
grid-area: aside;
flex-shrink: 0;
align-self: center;
}

Expand Down

0 comments on commit 331c01d

Please sign in to comment.