[HOP-63] Generate Styled System Tokens from StyleDictionary #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
alexasselin008
commented
Nov 1, 2023
•
alexasselin008
commented
- Added token generation in styled-system from the tokens project
- Added dev dependencies to tokens for both the docs and the styled-system, since they depend on the files generated from the build
- Removed the --parallel from the build command, so the build follow their natural order of dependencies
# Conflicts: # package.json # pnpm-lock.yaml
… in chromatic 6.5
…en added in chromatic 6.5" This reverts commit 7d92bdd.
# Conflicts: # .storybook/main.ts # package.json # pnpm-lock.yaml
…yled-system package. Added a hop-light and hop-dark class at the root so css can properly target color changes.
# Conflicts: # packages/styled-system/src/tokens/TokenProvider.tsx # packages/styled-system/src/tokens/generated/dark-semantic-tokens.ts # packages/styled-system/src/tokens/generated/light-tokens.ts # packages/styled-system/src/tokens/tokens.ts
|
✅ Deploy Preview for wl-hopper ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
alexasselin008
changed the title
# Conflicts: # pnpm-lock.yaml
# Conflicts: # pnpm-lock.yaml
# Conflicts: # packages/styled-system/package.json # packages/styled-system/src/tokens/generated/dark-semantic-tokens.ts # packages/styled-system/src/tokens/generated/light-tokens.ts # pnpm-lock.yaml
alexasselin008
changed the title
franckgaudin
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.