Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganized grouping of props to follow RAC #534

Merged
merged 4 commits into from
Nov 28, 2024
Merged

Reorganized grouping of props to follow RAC #534

merged 4 commits into from
Nov 28, 2024

Conversation

fraincs
Copy link
Contributor

@fraincs fraincs commented Nov 28, 2024

Grouping of props in the documentation props table was flaky, in some instances isDisabled was considered an accessibility prop, where in other place it was not. This PR follows RAC ways of grouping props, while making sure than an id? string is considered an accessibility prop and an id? key is considered exposed in the "default" props.

Copy link

changeset-bot bot commented Nov 28, 2024

⚠️ No Changeset found

Latest commit: ce719b4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Nov 28, 2024

Deploy Preview for wl-hopper ready!

Name Link
🔨 Latest commit ce719b4
🔍 Latest deploy log https://app.netlify.com/sites/wl-hopper/deploys/674882f776aec100073fa6fc
😎 Deploy Preview https://deploy-preview-534--wl-hopper.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alexasselin008 alexasselin008 marked this pull request as ready for review November 28, 2024 15:03
@fraincs fraincs merged commit 709b356 into main Nov 28, 2024
8 checks passed
@fraincs fraincs deleted the feature/ds-484 branch November 28, 2024 15:04
Copy link
Contributor

View Storybook

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants