Skip to content

Commit

Permalink
Change build target to target es2019. Some tools (storybook) do not s…
Browse files Browse the repository at this point in the history
…upport ES2020 synthax. I had a super hard time changing the tool config to accept this, so instead i'm compiling hopper in an older version
  • Loading branch information
alexasselin008 committed Dec 19, 2023
1 parent 2b459f6 commit f49a6c5
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 1 deletion.
7 changes: 7 additions & 0 deletions .changeset/tall-avocados-glow.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@hopper-ui/styled-system": patch
"@hopper-ui/components": patch
"@hopper-ui/icons": patch
---

Changed build target to target ES2019
3 changes: 2 additions & 1 deletion packages/components/tsup.build.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { defineBuildConfig } from "@workleap/tsup-configs";

export default defineBuildConfig({
entry: ["./src/**/src/*.(ts|tsx)"]
entry: ["./src/**/src/*.(ts|tsx)"],
target: "es2019" // We set target ES2019 since ES2020 syntax is not supported by older versions of storybook (used in orbiter)
});
1 change: 1 addition & 0 deletions packages/icons/tsup.build.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import packageJson from "./package.json";

export default defineBuildConfig({
entry: ["./src/**/*.(ts|tsx)"],
target: "es2019", // We set target ES2019 since ES2020 syntax is not supported by older versions of storybook (used in orbiter)
esbuildPlugins: [
createCssModuleEsbuildPlugin({
generateScopedName: "[name]__[local]___[hash:base64:5]",
Expand Down
1 change: 1 addition & 0 deletions packages/styled-system/tsup.build.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import packageJson from "./package.json";

export default defineBuildConfig({
entry: ["./src/**/*.(ts|tsx)"],
target: "es2019", // We set target ES2019 since ES2020 syntax is not supported by older versions of storybook (used in orbiter)
esbuildPlugins: [
createCssModuleEsbuildPlugin({
generateScopedName: "[name]__[local]___[hash:base64:5]",
Expand Down

0 comments on commit f49a6c5

Please sign in to comment.