feat: update code with Pull request comments

gsoft-inc · May 14, 2024 · dbe2eb6 · dbe2eb6
1 parent 73037f3
commit dbe2eb6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/svg-icons/scripts/changeColorPlugin.ts b/packages/svg-icons/scripts/changeColorPlugin.ts
@@ -20,7 +20,7 @@ export const changeColorPlugin = {
                 enter: (node: XastElement) => {
                     for (const [nodeName, nodeValue] of Object.entries(node.attributes)) {
                         if (colorsProps.has(nodeName)) {
-                            let value = nodeValue as string;
+                            let value = nodeValue;
 
                             if (colors[value]) {
                                 value = colors[value];

diff --git a/packages/svg-icons/scripts/svgoConfig.ts b/packages/svg-icons/scripts/svgoConfig.ts
@@ -11,14 +11,14 @@ import {
     WhiteExadecimal
 } from "./constants.ts";
 
-export const colors = {
+export const colors: { [key: string]: string } = {
     [PrimaryIconColor]: `var(--hop-Icon-primary-icon, ${PrimaryIconColor})`,
     [WarningWeakIconColor]: `var(--hop-Icon-warning-icon-weak, ${WarningWeakIconColor})`,
     [White]: `var(--hop-Richicon-placeholder-fill, ${WhiteExadecimal})`,
     [WhiteExadecimal]: `var(--hop-Richicon-placeholder-fill, ${WhiteExadecimal})`,
     [DecorativeOption7IconColor]: `var(--hop-Richicon-placeholder-background, ${DecorativeOption7IconColor})`,
     [DecorativeOption7SurfaceColor]: `var(--hop-Richicon-placeholder-shadow, ${DecorativeOption7SurfaceColor})`
-} satisfies Record<string, string>;
+};
 
 const config: Config = {
     multipass: true,