[DS-515] Add required examples with nece

gsoft-inc · Dec 23, 2024 · 5c69335 · 5c69335
1 parent 83137e9
commit 5c69335
Show file tree

Hide file tree

Showing 6 changed files with 25 additions and 6 deletions.
diff --git a/.changeset/gentle-monkeys-admire.md b/.changeset/gentle-monkeys-admire.md
@@ -0,0 +1,5 @@
+---
+"@hopper-ui/components": patch
+---
+
+Fix necessityIndicator not appearing when it's a label
diff --git a/apps/docs/content/components/content/Label.mdx b/apps/docs/content/components/content/Label.mdx
@@ -35,9 +35,13 @@ The label component has a default color, but it can be easily overridden.
 <Example src="typography/Label/docs/color" />
 
 ### Required
-The label component can be marked as required.
+The label component can be marked as required. You can customize the necessity indicator, such as using an asterisk.
 
-<Example src="typography/Label/docs/required" />
+<Example src="typography/Label/docs/required1" />
+
+Or a label.
+
+<Example src="typography/Label/docs/required2" />
 
 <FeatureFlag flag="next">
     ## Advanced customization

diff --git a/apps/docs/examples/Preview.ts b/apps/docs/examples/Preview.ts
@@ -407,8 +407,11 @@ export const Previews: Record<string, Preview> = {
     "typography/Label/docs/color": {
         component: lazy(() => import("@/../../packages/components/src/typography/Label/docs/color.tsx"))
     },
-    "typography/Label/docs/required": {
-        component: lazy(() => import("@/../../packages/components/src/typography/Label/docs/required.tsx"))
+    "typography/Label/docs/required1": {
+        component: lazy(() => import("@/../../packages/components/src/typography/Label/docs/required1.tsx"))
+    },
+    "typography/Label/docs/required2": {
+        component: lazy(() => import("@/../../packages/components/src/typography/Label/docs/required2.tsx"))
     },
     "typography/Label/docs/advancedCustomization": {
         component: lazy(() => import("@/../../packages/components/src/typography/Label/docs/advancedCustomization.tsx"))

diff --git a/packages/components/src/typography/Label/docs/required1.tsx b/packages/components/src/typography/Label/docs/required1.tsx
@@ -0,0 +1,7 @@
+import { Label } from "@hopper-ui/components";
+
+export default function Example() {
+    return (
+        <Label isRequired necessityIndicator="asterisk">Username</Label>
+    );
+}
diff --git a/...ts/src/typography/Label/docs/required.tsx → ...s/src/typography/Label/docs/required2.tsx b/...ts/src/typography/Label/docs/required.tsx → ...s/src/typography/Label/docs/required2.tsx
@@ -2,6 +2,6 @@ import { Label } from "@hopper-ui/components";
 
 export default function Example() {
     return (
-        <Label isRequired>Username</Label>
+        <Label isRequired necessityIndicator="label">Username</Label>
     );
 }
diff --git a/packages/components/src/typography/Label/src/Label.tsx b/packages/components/src/typography/Label/src/Label.tsx
@@ -79,7 +79,7 @@ function Label(props: LabelProps, ref: ForwardedRef<HTMLLabelElement>) {
             {...filteredProps}
         >
             {children}
-            {(necessityIndicator === "label" && !isRequired) && <span className={styles["hop-Label__label-indicator"]}> ({necessityLabel})</span>}
+            {necessityIndicator === "label" && isRequired && <span className={styles["hop-Label__label-indicator"]}> ({necessityLabel})</span>}
             {necessityIndicator === "asterisk" && isRequired && requiredIndicator}
         </RACLabel>
     );