Skip to content

Commit

Permalink
Use .NET SDK 8 and CodingStandard (#81)
Browse files Browse the repository at this point in the history
  • Loading branch information
meziantou authored Aug 1, 2024
1 parent 9a93a6c commit adee13a
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 20 deletions.
2 changes: 1 addition & 1 deletion global.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"sdk": {
"version": "6.0.424",
"version": "8.0.303",
"rollForward": "latestMinor",
"allowPrerelease": false
}
Expand Down
20 changes: 2 additions & 18 deletions src/Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -3,40 +3,24 @@
<Copyright>Copyright © Workleap. $([System.DateTime]::UtcNow.ToString(yyyy))</Copyright>
<Authors>Workleap</Authors>
<Owners>Workleap</Owners>
<PackageProjectUrl>https://github.com/gsoft-inc/wl-extensions-configuration-secrets</PackageProjectUrl>
<PublishRepositoryUrl>true</PublishRepositoryUrl>
<PackageLicenseExpression>Apache-2.0</PackageLicenseExpression>
<LangVersion>10</LangVersion>
<Nullable>enable</Nullable>
<ImplicitUsings>disable</ImplicitUsings>
<AnalysisLevel>latest-All</AnalysisLevel>
<Description>Allows storing configuration values in Azure Key Vault Secrets, using the right Azure credentials based on the current environment.</Description>
</PropertyGroup>

<PropertyGroup Condition=" '$(Configuration)' == 'Release' ">
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="StyleCop.Analyzers" Version="1.2.0-beta.556">
<PackageReference Include="Workleap.DotNet.CodingStandards" Version="0.6.0">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
</PackageReference>
<PackageReference Include="GitVersion.MsBuild" Version="5.12.0" Condition=" '$(Configuration)' == 'Release' ">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
</PackageReference>
</ItemGroup>

<!-- https://learn.microsoft.com/en-us/dotnet/standard/library-guidance/sourcelink -->
<PropertyGroup Condition=" '$(GITHUB_ACTIONS)' == 'true' Or '$(TF_BUILD)' == 'true' ">
<ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
<EmbedUntrackedSources>true</EmbedUntrackedSources>
</PropertyGroup>
<ItemGroup Condition=" '$(GITHUB_ACTIONS)' == 'true' ">
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="All" />
</ItemGroup>

<ItemGroup Condition="$(MSBuildProjectName.Contains('Tests'))">
<Using Include="Xunit" />
<Using Include="Xunit.Abstractions" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ public enum KeyVaultKind
/// Represents the Key Vault where we store keys and secrets related to the application configuration.
/// </summary>
ApplicationConfiguration,

/// <summary>
/// Represents the Key Vault where we store any keys and secrets associated to users.
/// </summary>
Expand Down

0 comments on commit adee13a

Please sign in to comment.