Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IDP-976] Post QA fixes #9

Merged
merged 1 commit into from
Mar 7, 2024
Merged

[IDP-976] Post QA fixes #9

merged 1 commit into from
Mar 7, 2024

Conversation

asimmon
Copy link
Member

@asimmon asimmon commented Mar 7, 2024

Changes:

csharp_style_allow_blank_line_after_token_in_arrow_expression_clause_experimental set to true, because we use both styles:

MyMethod() =>
    { expression (usually a multi-line expression) }

// AND

MyMethod()
    => { expression (usually a single-line expression }

IDE0200 suggests to use method groups instead of lambda expressions, but there's a bug. Sometimes it shows the warning but it is impossible to use a method group. See example where we capture a variable and we still get a warning. Nullables also play a role in this equation, but the warning should not have been there as we capture an external variable:

image

@asimmon asimmon requested a review from a team as a code owner March 7, 2024 15:57
@asimmon asimmon merged commit 15820ca into main Mar 7, 2024
3 checks passed
@asimmon asimmon deleted the feature/idp-976-fix branch March 7, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants