Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IDP-2269] Wait 3 days of release age unless it's Workleap dependencies #14

Merged
merged 10 commits into from
Sep 24, 2024

Conversation

asimmon
Copy link
Member

@asimmon asimmon commented Sep 23, 2024

Important

I ended up scope creeping this PR as there were a few referenced packages in the system tests that did not exist in nuget.org (ex: Hangfire.NetCore 1.7.0). Some other packages were private (Hangfire Pro). The code style was a mess. Method names weren't explanatory, so I fixed that too.

Planned changes

  • Wait 3 days of release age unless it's Workleap dependencies.
  • Add system tests.

Scope creep

  • Auto-merge more Microsoft/well-known dependencies.
  • Use case-insensitive regexes.
  • Use coding standards.
  • Improve tests and method names.
  • Inject (more) language hints in raw string literals.

default.json Outdated Show resolved Hide resolved
default.json Outdated Show resolved Hide resolved
default.json Outdated Show resolved Hide resolved
default.json Show resolved Hide resolved
@asimmon asimmon marked this pull request as ready for review September 23, 2024 18:19
@asimmon asimmon requested a review from a team as a code owner September 23, 2024 18:19
default.json Outdated Show resolved Hide resolved
meziantou
meziantou previously approved these changes Sep 23, 2024
default.json Outdated Show resolved Hide resolved
meziantou
meziantou previously approved these changes Sep 23, 2024
default.json Outdated Show resolved Hide resolved
@asimmon asimmon merged commit 0951dae into main Sep 24, 2024
2 checks passed
@asimmon asimmon deleted the feature/idp-2269 branch September 24, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants