Skip to content

Commit

Permalink
Expose terminationGracePeriodSeconds
Browse files Browse the repository at this point in the history
  • Loading branch information
Yalpe committed Oct 17, 2024
1 parent 2ccb115 commit 2db30df
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
2 changes: 1 addition & 1 deletion charts/aspnetcore/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v2
name: aspnetcore
description: A generic Helm chart for ASP.NET Core services
version: 2.1.1
version: 2.2.0
home: https://github.com/gsoft-inc/gsoft-helm-charts
sources:
- https://github.com/gsoft-inc/gsoft-helm-charts
Expand Down
1 change: 1 addition & 0 deletions charts/aspnetcore/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ spec:
{{- end }}
spec:
serviceAccountName: {{ include "aspnetcore.serviceAccountName" . }}
terminationGracePeriodSeconds: {{ .Values.terminationGracePeriodSeconds }}
containers:
- name: {{ .Chart.Name }}-container
image: "{{ .Values.image.registry }}/{{ .Values.image.repository }}:{{ .Values.image.tag }}"
Expand Down
4 changes: 3 additions & 1 deletion charts/aspnetcore/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@
## We set this to 2 by default because the PodDisruptionBudget is set to minimum 1 running replica and having only one replica creates a deadlock while draining nodes during cluster upgrades
replicaCount: 2

## @param service.terminationGracePeriodSeconds The duration in seconds the pod needs to terminate gracefully
terminationGracePeriodSeconds: 30

## @param environment The ASP.NET Core environment name (DOTNET_ENVIRONMENT)
##
environment: Development
Expand Down Expand Up @@ -31,7 +34,6 @@ image:
## @param service.name Name of the service, automatically generated from the release name if not specified
## @param service.port ASP.NET Core service HTTP port
## @param service.annotations Additional custom annotations for ASP.NET Core service
##
service:
name: ""
port: 80
Expand Down

0 comments on commit 2db30df

Please sign in to comment.